Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove additional copies from tridiagonal eigensolver #819

Merged
merged 3 commits into from
Apr 12, 2023
Merged

remove additional copies from tridiagonal eigensolver #819

merged 3 commits into from
Apr 12, 2023

Conversation

rasolca
Copy link
Collaborator

@rasolca rasolca commented Mar 27, 2023

See #817 for performance results.

@rasolca rasolca added this to the Cleanup milestone Mar 27, 2023
msimberg
msimberg approved these changes Mar 28, 2023
View reviewed changes
Copy link
Collaborator

@msimberg msimberg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As usual, my algorithmic understanding of this is low. Looks good to me otherwise.

@rasolca rasolca mentioned this pull request Apr 11, 2023
Merged
@rasolca rasolca self-assigned this Apr 11, 2023
@rasolca
Copy link
Collaborator Author

rasolca commented Apr 11, 2023

cscs-ci run

albestro
albestro approved these changes Apr 12, 2023
View reviewed changes
Copy link
Collaborator

@albestro albestro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't check all the details, but I got the general idea, and it seems ok.

Just a minor comment on the documentation of the workspace, where formatting seems not consistent, but it is anyway readable.

@rasolca
Copy link
Collaborator Author

rasolca commented Apr 12, 2023

cscs-ci run

@rasolca rasolca merged commit 2a2641a into master Apr 12, 2023
@rasolca rasolca deleted the rasolca/tridiag-2 branch April 12, 2023 09:48
albestro added a commit that referenced this pull request Aug 24, 2023
@albestro
remove unused GPU kernel for stablePartitionForDeflation
04b6420 
it was probably unused since #819
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@albestro albestro albestro approved these changes

@msimberg msimberg msimberg approved these changes

Assignees

@rasolca rasolca

Labels
Priority:Medium
Projects
DLA-F Planning
Archived in project
Milestone
Cleanup
Development

Successfully merging this pull request may close these issues.
3 participants
@rasolca @msimberg @albestro